Re-throw ResponseException as AssertionError in BasicLicenseUpgradeIT #67182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that in a slow machine the cluster state updates take a while to be applied, the license information is published with priority NORMAL, meaning that it can take a while for the License information to become available. This can lead to race conditions. In order to wait until the license information is available, the tests use assertBusy, but assertBusy only retries if an AssertionException is raised, for that reason we rethrow http client exceptions as AssertionExceptions so the check can be retried. Closes elastic#64578
fcofdez
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
reviewed
Jan 7, 2021
| Map<String, Object> licenseMap = (Map<String, Object>) licenseResponseMap.get("license"); | ||
| assertEquals("basic", licenseMap.get("type")); | ||
| assertEquals("active", licenseMap.get("status")); | ||
| try { |
There was a problem hiding this comment.
Does this work as an alternative? This way it only retries on a 404:
final Request request = new Request("GET", "/_license");
request.addParameter("ignore", "404");
Response licenseResponse = client().performRequest(request);
assertOK(licenseResponse);
There was a problem hiding this comment.
I didn't know about the ignore parameter, that looks much better 👍
There was a problem hiding this comment.
Full disclosure: nor did I until just now 😁
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
Jan 8, 2021
It's possible that in a slow machine the cluster state updates take a while to be applied, the license information is published with NORMAL priority, meaning that it can take a while for the License information to become available. This can lead to race conditions. In order to wait until the license information is available, the tests use assertBusy, but assertBusy only retries if an AssertionException is raised, for that reason we use the ignore parameter in the http client and later check that the response was correct, meaning that the check can be retried if the license information is not ready yet. Closes elastic#64578 Backport of elastic#67182
fcofdez
added a commit
that referenced
this pull request
Jan 8, 2021
…#67212) It's possible that in a slow machine the cluster state updates take a while to be applied, the license information is published with NORMAL priority, meaning that it can take a while for the License information to become available. This can lead to race conditions. In order to wait until the license information is available, the tests use assertBusy, but assertBusy only retries if an AssertionException is raised, for that reason we use the ignore parameter in the http client and later check that the response was correct, meaning that the check can be retried if the license information is not ready yet. Closes #64578 Backport of #67182
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
Jan 27, 2021
It's possible that in a slow machine the cluster state updates take a while to be applied, the license information is published with NORMAL priority, meaning that it can take a while for the License information to become available. This can lead to race conditions. In order to wait until the license information is available, the tests use assertBusy, but assertBusy only retries if an AssertionException is raised, for that reason we use the ignore parameter in the http client and later check that the response was correct, meaning that the check can be retried if the license information is not ready yet. Closes elastic#64578 Backport of elastic#67182
fcofdez
added a commit
that referenced
this pull request
Jan 27, 2021
…#68046) It's possible that in a slow machine the cluster state updates take a while to be applied, the license information is published with NORMAL priority, meaning that it can take a while for the License information to become available. This can lead to race conditions. In order to wait until the license information is available, the tests use assertBusy, but assertBusy only retries if an AssertionException is raised, for that reason we use the ignore parameter in the http client and later check that the response was correct, meaning that the check can be retried if the license information is not ready yet. Closes #64578 Backport of #67182
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 20, 2024
Relates: #110729 The `testQueryDLSFLSRolesShowAsDisabled` failed intermittently and my theory is that it's because applying the license of the cluster to cluster state has `NORMAL` priority and therefore sometimes (very rarely) takes more than 10 seconds. There are some related discussions to this, see: #67182, #64578 Since we're not testing the actual license lifecycle in this test, but instead how an applied license impacts the query roles API, I changed the approach to use the synchronous `/_license/start_trial` API in a `@before` so we can be sure the license was applied before we start testing. An alternative to this fix could be to increase the timeout.
lkts
pushed a commit
to lkts/elasticsearch
that referenced
this pull request
Aug 20, 2024
Relates: elastic#110729 The `testQueryDLSFLSRolesShowAsDisabled` failed intermittently and my theory is that it's because applying the license of the cluster to cluster state has `NORMAL` priority and therefore sometimes (very rarely) takes more than 10 seconds. There are some related discussions to this, see: elastic#67182, elastic#64578 Since we're not testing the actual license lifecycle in this test, but instead how an applied license impacts the query roles API, I changed the approach to use the synchronous `/_license/start_trial` API in a `@before` so we can be sure the license was applied before we start testing. An alternative to this fix could be to increase the timeout.
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
Relates: elastic#110729 The `testQueryDLSFLSRolesShowAsDisabled` failed intermittently and my theory is that it's because applying the license of the cluster to cluster state has `NORMAL` priority and therefore sometimes (very rarely) takes more than 10 seconds. There are some related discussions to this, see: elastic#67182, elastic#64578 Since we're not testing the actual license lifecycle in this test, but instead how an applied license impacts the query roles API, I changed the approach to use the synchronous `/_license/start_trial` API in a `@before` so we can be sure the license was applied before we start testing. An alternative to this fix could be to increase the timeout.
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Sep 5, 2024
Relates: elastic#110729 The `testQueryDLSFLSRolesShowAsDisabled` failed intermittently and my theory is that it's because applying the license of the cluster to cluster state has `NORMAL` priority and therefore sometimes (very rarely) takes more than 10 seconds. There are some related discussions to this, see: elastic#67182, elastic#64578 Since we're not testing the actual license lifecycle in this test, but instead how an applied license impacts the query roles API, I changed the approach to use the synchronous `/_license/start_trial` API in a `@before` so we can be sure the license was applied before we start testing. An alternative to this fix could be to increase the timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that in a slow machine the cluster state updates
take a while to be applied, the license information is published
with NORMAL priority, meaning that it can take a while for the
License information to become available. This can lead to race
conditions. In order to wait until the license information is
available, the tests use assertBusy, but assertBusy only retries
if an AssertionException is raised, for that reason we use the
ignoreparameter in the http client and later check that theresponse was correct, meaning that the check can be retried
if the license information is not ready yet.
Closes #64578