Introduce ES_JAVA_HOME #68954
Merged
Introduce ES_JAVA_HOME #68954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a dedicated envirnoment variable ES_JAVA_HOME to determine the JDK used to start (if not using the bundled JDK). This environment variable will replace JAVA_HOME. The reason that we are making this change is because JAVA_HOME is a common environment variable and sometimes users have it set in their environment from other JDK applications that they have installed on their system. In this case, they would accidentally end up not using the bundled JDK despite their intentions. By using a dedicated environment variable specific to Elasticsearch, we avoid this potential for conflict. With this commit, we introduce the new enviroinment variable, and deprecate the use of JAVA_HOME. We will remove support for JAVA_HOME in a future commit.
|
@elasticmachine update branch |
jasontedor
added
the
:Delivery/Packaging
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
approved these changes
Feb 17, 2021
jasontedor
added a commit
that referenced
this pull request
Feb 17, 2021
This commit introduces a dedicated envirnoment variable ES_JAVA_HOME to determine the JDK used to start (if not using the bundled JDK). This environment variable will replace JAVA_HOME. The reason that we are making this change is because JAVA_HOME is a common environment variable and sometimes users have it set in their environment from other JDK applications that they have installed on their system. In this case, they would accidentally end up not using the bundled JDK despite their intentions. By using a dedicated environment variable specific to Elasticsearch, we avoid this potential for conflict. With this commit, we introduce the new environment variable, and deprecate the use of JAVA_HOME. We will remove support for JAVA_HOME in a future commit.
ghost
mentioned this pull request
4 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a dedicated envirnoment variable ES_JAVA_HOME to determine the JDK used to start (if not using the bundled JDK). This environment variable will replace JAVA_HOME. The reason that we are making this change is because JAVA_HOME is a common environment variable and sometimes users have it set in their environment from other JDK applications that they have installed on their system. In this case, they would accidentally end up not using the bundled JDK despite their intentions. By using a dedicated environment variable specific to Elasticsearch, we avoid this potential for conflict. With this commit, we introduce the new enviroinment variable, and deprecate the use of JAVA_HOME. We will remove support for JAVA_HOME in a future commit.
Closes #68848