Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: make RestSqlQueryAction thread-safe #69901

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Mar 3, 2021

Remove MediaType as instance variable from RestSqlQueryAction.
Similar fix with #69895, but the impact of the bug in 8.x was smaller.

@astefan astefan requested review from costin and matriv March 3, 2021 16:51
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Mar 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx!!!

Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astefan astefan merged commit 1d8d3c5 into elastic:master Mar 3, 2021
@astefan astefan deleted the rest_action_thread_safety branch March 3, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/SQL SQL querying >bug Team:QL (Deprecated) Meta label for query languages team v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants