SQL: Resolve attributes recursively for improved subquery support (#69765) #70322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we did not resolve the attributes recursively which meant that if a field or expression was re-aliased multiple times (through multiple levels of subqueries), the aliases were only resolved one level down. This led to failed query translation because
ReferenceAttribute
s were pointing to non-existing attributes during query translation.For example the query
failed during translation because the
OrderBy
resolved thej
ReferenceAttribute to anotheri
ReferenceAttribute that was later removed by an Optimization:By resolving the
Attributes
recursively bothj{r}
andi{r}
will resolve totest.int{f}
above:The scope of recursive resolution depends on how the
AttributeMap
is constructed and populated.Fixes #67237