Handle the existence of system data streams in Get Aliases API #73244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjusts the behavior of the Get Aliases API to more thoroughly prevent errors and warnings from being emitted unnecessarily from the Get Aliases API when system data streams exist. This is a hack which should be removed as soon as possible.
gwbrown
added
blocker
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
gwbrown
commented
May 19, 2021
| // system index that backs system data stream | ||
| if (indexAbstraction.getParentDataStream() != null) { | ||
| if (indexAbstraction.getParentDataStream().isSystem() == false) { | ||
| throw new IllegalStateException("system index is part of a data stream that is not a system data stream"); |
There was a problem hiding this comment.
I think this is a worth candidate for promoting to an assert - we should never hit this case, right?
There was a problem hiding this comment.
it should never hit this case but I prefer this actually being detected in the wild since we don't run with assertions on normally
There was a problem hiding this comment.
++, I meant along the lines of:
assert false : "this means you probably wrote a bug that lets system indices be part of non-system data streams";
throw new IllegalStateException("system index is part of a data stream that is not a system data stream"); This shouldn't block the PR though, more maybe as a follow-up?
tvernum
approved these changes
May 19, 2021
rjernst
approved these changes
May 19, 2021
williamrandolph
approved these changes
May 19, 2021
jaymode
pushed a commit
to jaymode/elasticsearch
that referenced
this pull request
May 19, 2021
…ic#73244) This commit adjusts the behavior of the Get Aliases API to more thoroughly prevent errors and warnings from being emitted unnecessarily from the Get Aliases API by retrieving all indices including system ones and only warning in the post processing of the action. Additionally, the IndexAbstractionResolver has been updated to properly handle system data streams when evaluating visibility. Closes elastic#73218 Co-authored-by: jaymode <jay@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts the behavior of the Get Aliases API to more
thoroughly prevent errors and warnings from being emitted unnecessarily
from the Get Aliases API by retrieving all indices including system ones
and only warning in the post processing of the action.
Additionally, the IndexAbstractionResolver has been updated to properly
handle system data streams when evaluating visibility.
Closes #73218
Co-authored-by: jaymode jay@elastic.co