Handle cgroups v2 in OsProbe
#77128
Merged
Handle cgroups v2 in OsProbe
#77128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#76812. `OsProbe` was only capable of handle cgroup data in the v1 format. However, Debian 11 uses cgroups v2 by default, and Elasticsearch isn't capable of reporting any cgroup information. Therefore, add support for the v2 layout.
pugnascotia
added
>enhancement
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Sep 1, 2021
ChrisHegarty
reviewed
Sep 1, 2021
| permission java.io.FilePermission "/sys/fs/cgroup/cpuacct/-", "read"; | ||
| permission java.io.FilePermission "/sys/fs/cgroup/memory", "read"; | ||
| permission java.io.FilePermission "/sys/fs/cgroup/memory/-", "read"; | ||
| permission java.io.FilePermission "/sys/fs/cgroup/-", "read"; |
There was a problem hiding this comment.
This recursive file permission grant looks good to me.
pugnascotia
added
the
:Delivery/Packaging
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
Hi @pugnascotia, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/part-2 |
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Sep 4, 2021
* master: (128 commits) Mute DieWithDignityIT (elastic#77283) Fix randomization in MlNodeShutdownIT (elastic#77281) Add target_node_name for REPLACE shutdown type (elastic#77151) [DOCS] Adds information about version compatibility headers (elastic#77096) Fix template equals when mappings are wrapped (elastic#77008) Fix TextFieldMapper Retaining a Reference to its Builder (elastic#77251) Move die with dignity to be a test module (elastic#77136) Update task names for rest compatiblity (elastic#75267) [ML] adjusting bwc serialization for elastic#77256 (elastic#77257) Move `index.hidden` from Static to Dynamic settings (elastic#77218) Handle cgroups v2 in `OsProbe` (elastic#77128) Choose postings format from FieldMapper instead of MappedFieldType (elastic#77234) Add segment sorter for data streams (elastic#75195) Update skip after backport (elastic#77212) [ML] adding new defer_definition_decompression parameter to put trained model API (elastic#77189) [ML] Fix bug in inference stats persister for when feature reset is called Only check replicas in cancelling existing recoveries. (elastic#60564) Format `AbstractFilteringTestCase` (elastic#77217) [DOCS] Fixes line breaks. (elastic#77248) Convert 'routing' values in REST API tests to strings ... # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Sep 6, 2021
Closes elastic#76812. Closes elastic#77126. OsProbe was only capable of handle cgroup data in the v1 format. However, Debian 11 uses cgroups v2 by default, and Elasticsearch isn't capable of reporting any cgroup information. Therefore, add support for the v2 layout. Note that we have to open access to all of /sys/fs/cgroup because with cgroups v2, the files we need are in an unpredictably location.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 6, 2021
* Handle cgroups v2 in `OsProbe` (#77128) Closes #76812. Closes #77126. OsProbe was only capable of handle cgroup data in the v1 format. However, Debian 11 uses cgroups v2 by default, and Elasticsearch isn't capable of reporting any cgroup information. Therefore, add support for the v2 layout. Note that we have to open access to all of /sys/fs/cgroup because with cgroups v2, the files we need are in an unpredictably location. * Handle a max memory value of 'max' (#77289) * Handle a max memory value of 'max' * Update docs/changelog/77289.yaml * Delete 77289.yaml * Fixes to backport * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76812. Closes #77126.
OsProbewas only capable of handle cgroup data in the v1 format.However, Debian 11 uses cgroups v2 by default, and Elasticsearch isn't
capable of reporting any cgroup information. Therefore, add support for
the v2 layout.
Note that we have to open access to all of
/sys/fs/cgroupbecause withcgroups v2, the files we need are in an unpredictably location.