Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update saml acs with new URL #77146

Merged

Conversation

lockewritesdocs
Copy link
Contributor

Removes the skipped tests from #77038 and updates build.gradle with the new 'xpack.security.authc.realms.saml.saml1.sp.acs' URL.

@lockewritesdocs lockewritesdocs added the >docs General docs changes label Sep 1, 2021
@lockewritesdocs lockewritesdocs self-assigned this Sep 1, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Sep 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@lockewritesdocs
Copy link
Contributor Author

https://github.com/elastic/elasticsearch/pull/77038/files#diff-3c61752c92cdf941a98a67fb49a65d08a61efe20009bdd4bba8ad229278f7d6eR55

@jkakavas, what are you wanting to fix in that file? None of the tests were skipped as part of the changes in #77038. Are you suggesting that we uncomment the skipped tests like this one?

@jkakavas
Copy link
Member

jkakavas commented Sep 1, 2021

https://github.com/elastic/elasticsearch/pull/77038/files#diff-3c61752c92cdf941a98a67fb49a65d08a61efe20009bdd4bba8ad229278f7d6eR55

@jkakavas, what are you wanting to fix in that file? None of the tests were skipped as part of the changes in #77038. Are you suggesting that we uncomment the skipped tests like this one?

https://github.com/elastic/elasticsearch/pull/77038/files#diff-3c61752c92cdf941a98a67fb49a65d08a61efe20009bdd4bba8ad229278f7d6eR55 is actually a link to a line that you added in 77038 that mutes a doc test in x-pack/docs/en/rest-api/security/saml-sp-metadata.asciidoc

@lockewritesdocs
Copy link
Contributor Author

https://github.com/elastic/elasticsearch/pull/77038/files#diff-3c61752c92cdf941a98a67fb49a65d08a61efe20009bdd4bba8ad229278f7d6eR55 is actually a link to a line that you added in 77038 that mutes a doc test in x-pack/docs/en/rest-api/security/saml-sp-metadata.asciidoc

Got it! Thanks for clarifying. The link just opened the entire diff, so I wasn't sure what you meant. I'll fix now 👍

@lockewritesdocs
Copy link
Contributor Author

@jkakavas, I think we're good to merge now. Just wanted you to give a 👍 before merging and backporting.

Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the ping!

@lockewritesdocs lockewritesdocs merged commit 7ba942d into elastic:7.x Sep 2, 2021
@lockewritesdocs lockewritesdocs deleted the docs__update-saml-url-gradle branch September 2, 2021 11:47
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Sep 2, 2021
* [DOCS] Update saml acs with new URL

* Unmute tests :mute
lockewritesdocs pushed a commit that referenced this pull request Sep 2, 2021
* [DOCS] Update saml acs with new URL

* Unmute tests :mute
lockewritesdocs pushed a commit that referenced this pull request Sep 2, 2021
* [DOCS] Update saml acs with new URL

* Unmute tests :mute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes Team:Docs Meta label for docs team v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants