WIP manage lifecycle of outgoing connections #77253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
added
the
:Distributed Coordination/Cluster Coordination
DaveCTurner
force-pushed
the
2021-09-03-releasable-connections
branch
11 times, most recently
from
ec2dd05 to
5c0937d
Compare
Today we open connections to other nodes in various places and largely assume that they remain open as needed, only closing them when applying a cluster state that removes the remote node from the cluster. This isn't ideal: we might preserve unnecessary connections to remote nodes that aren't in the cluster if they never manage to join the cluster, and we might also disconnect from a node that left the cluster while it's in the process of re-joining too (see #TODO). With this commit we move to a model in which each user of a connection to a remote node acquires a reference to the connection that must be released once it's no longer needed. Connections remain open while there are any live references, but are now actively closed when all references are released. Fixes #TODO
DaveCTurner
force-pushed
the
2021-09-03-releasable-connections
branch
from
4d0c1c9 to
8e2a625
Compare
DaveCTurner
force-pushed
the
2021-09-03-releasable-connections
branch
2 times, most recently
from
ba4a63f to
a154fcc
Compare
DaveCTurner
force-pushed
the
2021-09-03-releasable-connections
branch
from
a154fcc to
c03efe1
Compare
|
Closing in favour of #77295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards a fix for #67873; just opening this so that CI can tell me how badly I broke other stuff.