-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust SearchableSnapshotsBlobStoreCacheIntegTests.testBlobStoreCache #77758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test sometimes fails (elastic#77753) when it tries to refresh the snapshot blob cache index while it wasn't created at all due to the test index being completely empty with 0 documents indexed. Having an empty index in this test does not make much sense because the index will contain no segments and therefore no segments file to cache in the system index. This pull request adjusts the test to always index at least some docs.
tlrx
added
>test
Issues or PRs that are addressing/adding tests
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
v8.0.0
v7.16.0
v7.15.1
v7.14.3
labels
Sep 15, 2021
elasticmachine
added
the
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
label
Sep 15, 2021
Pinging @elastic/es-distributed (Team:Distributed) |
original-brownbear
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Armin |
💔 Backport failed
You can use sqren/backport to manually backport by running |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Sep 16, 2021
…elastic#77758) This test sometimes fails (elastic#77753) when it tries to refresh the snapshot blob cache index while it wasn't created at all due to the test index being completely empty with 0 documents indexed. Having an empty index in this test does not make much sense because the index will contain no segments and therefore no segments file to cache in the system index. This commit adjusts the test to always index at least some docs. Backport of elastic#77758
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Sep 16, 2021
…elastic#77758) This test sometimes fails (elastic#77753) when it tries to refresh the snapshot blob cache index while it wasn't created at all due to the test index being completely empty with 0 documents indexed. Having an empty index in this test does not make much sense because the index will contain no segments and therefore no segments file to cache in the system index. This commit adjusts the test to always index at least some docs. Backport of elastic#77758
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Sep 16, 2021
…elastic#77758) This test sometimes fails (elastic#77753) when it tries to refresh the snapshot blob cache index while it wasn't created at all due to the test index being completely empty with 0 documents indexed. Having an empty index in this test does not make much sense because the index will contain no segments and therefore no segments file to cache in the system index. This commit adjusts the test to always index at least some docs. Backport of elastic#77758
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…#77758) (#77848) This test sometimes fails (#77753) when it tries to refresh the snapshot blob cache index while it wasn't created at all due to the test index being completely empty with 0 documents indexed. Having an empty index in this test does not make much sense because the index will contain no segments and therefore no segments file to cache in the system index. This commit adjusts the test to always index at least some docs. Backport of #77758
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…#77758) (#77843) This test sometimes fails (#77753) when it tries to refresh the snapshot blob cache index while it wasn't created at all due to the test index being completely empty with 0 documents indexed. Having an empty index in this test does not make much sense because the index will contain no segments and therefore no segments file to cache in the system index. This commit adjusts the test to always index at least some docs. Backport of #77758
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2021
…#77758) (#77844) This test sometimes fails (#77753) when it tries to refresh the snapshot blob cache index while it wasn't created at all due to the test index being completely empty with 0 documents indexed. Having an empty index in this test does not make much sense because the index will contain no segments and therefore no segments file to cache in the system index. This commit adjusts the test to always index at least some docs. Backport of #77758 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Sep 18, 2021
* master: (185 commits) Implement get and containsKey in terms of the wrapped innerMap (elastic#77965) Adjust Lucene version and enable BWC tests (elastic#77933) Disable BWC to upgrade to Lucene-8.10-snapshot Reenable MlDistributedFailureIT [DOCS] Fix typo for `script.painless.regex.enabled` setting value (elastic#77853) Upgrade to Lucene-8.10.0-snapshot-bf2fcb53079 (elastic#77801) [DOCS] Fix ESS install lead-in (elastic#77887) Resolve thirdparty gradle plugin artifacts from mavencentral (elastic#77865) Reduce the number of times that `LifecycleExecutionState` is parsed when running a policy. (elastic#77863) Utility methods to add and remove backing indices from data streams (elastic#77778) Use Objects.equals() instead of == to compare strings (elastic#77840) [ML] prefer least allocated model when a new node is added to the cluster (elastic#77756) Deprecate ignore_throttled parameter (elastic#77479) Improve LifecycleExecutionState parsing. (elastic#77855) [DOCS] Removes deprecated word from HLRC title. (elastic#77851) Remove legacy geo code from AggregationResultUtils (elastic#77702) Adjust SearchableSnapshotsBlobStoreCacheIntegTests.testBlobStoreCache (elastic#77758) Laxify SecureSM to allow creation of the JDK's innocuous threads (elastic#77789) [Test] Reduce concurrency when testing creation of security index (elastic#75293) Refactor metric PipelineAggregation integration test (elastic#77548) ... # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
>test
Issues or PRs that are addressing/adding tests
v7.14.3
v7.15.1
v7.16.0
v8.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test sometimes fails (#77753) when it tries to refresh the
snapshot blob cache index while it wasn't created at all due to
the test index being completely empty with 0 documents indexed.
Having an empty index in this test does not make much sense
because the index will contain no segments and therefore no
segments file to cache in the system index.
This pull request adjusts the test to always index at least
some docs.