Don't use endianness reverse util for writing KeyStore file #78304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>non-issue
:Search/Search
elasticmachine
added
Team:Search
|
Pinging @elastic/es-search (Team:Search) |
|
Pinging @elastic/es-distributed (Team:Distributed) |
romseygeek
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Elasticsearch was upgraded to Lucene 9.0, the keystore mechanism for files was not changed and we are just reversing the endianness of the files for reading and writing. On the long term we want to write the file in the endianness of the data input so this PR does that. New files are writing in LE and a new version of the files is added. We handle the different endianness when reading files.
follow up of #73324