-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granting kibana_system reserved role access to "all" privileges to .internal.preview.alerts* index #80889
Conversation
Pinging @elastic/es-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am not very familiar with the alerts as data work. So this might not be the right question. But why do we have to prepend different strings to the .alerts
namespace? We already granted Kibana all access to .alerts*
, which seems to be a viable top-level namespace for covering all usages required by alerts-as-data? That is, is it more organised and easier if we use suffix instead of prefix for sub namespaces? i.e. instead of .internal.alerts*
, .preview.alerts*
and .internal.preview.alerts*
, we replace them with .alerts.internal.*
, .alerts.preview.*
, .alerts.internal_preview.*
?
@ywangd The way the new alerts as data feature is set up, it was intentional to separate the fields from the general |
💚 Backport successful |
This appears not to have made it back to |
…nternal.preview.alerts* index (elastic#80889)
Required for: elastic/kibana#116374
Summary
An extension of #76624 and #80746. Adding for the new rule preview feature that utilizes alerts as data and a reserved index for
kibana_system
user to read/write alerts. We are writing to a separate internal index than normal alerts so they won't show up with standard.internal.alerts*
queries, but still need the same permissions as "normal" alert indices