Handle partial search result with point in time #81349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, a search request with PIT would fail immediately if any associated indices are gone, which is inconsistent when allow_partial_search_results is true.
dnhatn
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
ywelsch
reviewed
Dec 7, 2021
There was a problem hiding this comment.
This PR changes two things:
- Make PIT work with allow_partial_results = true (previously it would fail)
- Change http response code when allow_partial_results = false
While the former looks ok for me, I'm worried a bit about the BWC implications of the latter, especially as this is being backported to 7.16.
Should we only do 1) here for the backport and follow-up with 2) in a separate PR?
I pushed 8b1be39 to revert the current behaviour when |
dnhatn
commented
Dec 7, 2021
| @@ -54,7 +54,7 @@ POST /_search <1> | |||
| } | |||
| } | |||
| -------------------------------------------------- | |||
| // TEST[catch:missing] | |||
| // TEST[catch:unavailable] | |||
There was a problem hiding this comment.
We have to change this as the allow_partial_results defaults to true.
|
Thanks Yannick! |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Dec 8, 2021
Today, a search request with PIT would fail immediately if any associated indices or nodes are gone, which is inconsistent when allow_partial_search_results is true. Relates elastic#81256
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Dec 8, 2021
Today, a search request with PIT would fail immediately if any associated indices or nodes are gone, which is inconsistent when allow_partial_search_results is true. Relates elastic#81256
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 8, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 22, 2021
* Handle partial search result with point in time (#81349) Today, a search request with PIT would fail immediately if any associated indices or nodes are gone, which is inconsistent when allow_partial_search_results is true. Relates #81256 * fix tests * Remove duplicated point-in-time doc * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, a search request with PIT would fail immediately if any associated indices or nodes are gone, which is inconsistent when
allow_partial_search_resultsis true.Relates #81256