Update gradle wrapper to 7.4 #81963
Update gradle wrapper to 7.4 #81963
Conversation
breskeby
added
>enhancement
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
force-pushed
the
update-gradle-74
branch
from
6e04779
to
f6a6dfa
Compare
breskeby
force-pushed
the
update-gradle-74
branch
from
f6a6dfa
to
e11bb07
Compare
breskeby
force-pushed
the
update-gradle-74
branch
3 times, most recently
from
c3dbfd2
to
29a9110
Compare
includes making checkstyle using the worker api
This reverts commit f6a6dfa92ed77c9ca890c4cae3c8b4894a009115.
breskeby
force-pushed
the
update-gradle-74
branch
from
29a9110
to
442e574
Compare
| @@ -68,6 +69,7 @@ public LicenseHeadersTask() { | |||
| * constructor can write to it. | |||
| */ | |||
| @InputFiles | |||
| @IgnoreEmptyDirectories | |||
There was a problem hiding this comment.
What is the deprecation exactly? When is the annotation required?
There was a problem hiding this comment.
The exact deprecation is "Relying on FileTrees for ignoring empty directories when using @SkipWhenEmpty has been deprecated" and here you can see how it affected our build when I initially tested 7.4-rc-1
https://gradle-enterprise.elastic.co/s/johhiz7bfeq7c/deprecations#0
There was a problem hiding this comment.
I read that documentation about 10 times and I'm still confused 😄
There was a problem hiding this comment.
My understanding is, that this fileTree is considered empty when @SkipWhenEmpty is used:
dir
|__emptyDir1
|__emptyDir2
but for non empty fileTree inputs like
dir
|__emptyDir1
|__someFile.txt
and
dir
|__emptyDir1
|__emptyDir2
|__someFile.txt
those two would not considered equal as they have different empty dirs in it. This in combination with @SkipWhenEmpty is deprecated. Adding @IgnoreEmptyDirectories makes both fileTrees considered to be identical by gradle when calculating inputs / outputs
breskeby
added
auto-backport-and-merge
* Make ForbiddenApisPrecommitPlugin plugin Gradle 8.0 compatible * Fix deprecations on ignoring empty folders for task inputs * Update Gradle wrapper to 7.4 GA
💔 Backport failed
You can use sqren/backport to manually backport by running |
* Make ForbiddenApisPrecommitPlugin plugin Gradle 8.0 compatible * Fix deprecations on ignoring empty folders for task inputs * Update Gradle wrapper to 7.4 GA # Conflicts: # build-tools-internal/performance/elasticsearch-build-tool-update.scenarios # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ForbiddenApisPrecommitPlugin.java # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/rest/compat/RestCompatTestTransformTask.java
* Make ForbiddenApisPrecommitPlugin plugin Gradle 8.0 compatible * Fix deprecations on ignoring empty folders for task inputs * Update Gradle wrapper to 7.4 GA # Conflicts: # build-tools-internal/performance/elasticsearch-build-tool-update.scenarios # build-tools-internal/src/main/resources/minimumGradleVersion
Update local Gradle wrapper to 7.4. We fix some deprecations on the way for ignoring empty directories
as task inputs when using @SkipWhenEmpty
Required more work on tweaking third party plugin
ForbiddenApisPrecommitPlugin