Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard intermediate results upon cancellation for stats endpoints #82685

Merged
merged 31 commits into from
Feb 10, 2022
Merged

Discard intermediate results upon cancellation for stats endpoints #82685

merged 31 commits into from
Feb 10, 2022

Conversation

gmarouli
Copy link
Contributor

@gmarouli gmarouli commented Jan 17, 2022 •
edited
Loading

Discard intermediate results when a stats request is cancelled.

Next tasks:

  • Discuss approach
  • Improve understanding of _cluster/state request
  • Check completeness, did we cover all the endpoints that cause problems
  • Implement tests
  • Pass tests

Resolves #82337

@gmarouli gmarouli added :Data Management/Stats Statistics tracking and retrieval APIs >bug Team:Data Management Meta label for data/management team and removed v8.1.0 labels Jan 17, 2022
@gmarouli
Copy link
Contributor Author

@elasticsearchmachine update branch

@gmarouli
Copy link
Contributor Author

@elasticmachine update branch

@gmarouli
Copy link
Contributor Author

@elasticmachine update branch

@gmarouli
Copy link
Contributor Author

gmarouli commented Feb 2, 2022

@elasticmachine update branch

@gmarouli
Copy link
Contributor Author

gmarouli commented Feb 2, 2022

@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample

@gmarouli
Copy link
Contributor Author

gmarouli commented Feb 3, 2022

@elasticmachine run elasticsearch-ci/part-1

@gmarouli gmarouli added the v8.2.0 label Feb 3, 2022
dakrone
dakrone approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me, I left an optional comment

server/src/main/java/org/elasticsearch/action/support/NodeResponseTracker.java Outdated Show resolved Hide resolved
DaveCTurner
DaveCTurner reviewed Feb 9, 2022
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @gmarouli, I left a handful of small comments.

docs/changelog/82685.yaml Show resolved Hide resolved
server/src/main/java/org/elasticsearch/tasks/CancellableTask.java Outdated Show resolved Hide resolved
...ain/java/org/elasticsearch/action/support/broadcast/node/TransportBroadcastByNodeAction.java Outdated Show resolved Hide resolved
...ain/java/org/elasticsearch/action/support/broadcast/node/TransportBroadcastByNodeAction.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/action/support/NodeResponseTracker.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/action/support/NodeResponseTracker.java Outdated Show resolved Hide resolved
@gmarouli
Copy link
Contributor Author

gmarouli commented Feb 9, 2022

@dakrone & @DaveCTurner Thank you very much for your comments!

@gmarouli
Copy link
Contributor Author

gmarouli commented Feb 9, 2022

@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample

@gmarouli
Copy link
Contributor Author

gmarouli commented Feb 9, 2022

@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample

@gmarouli
Copy link
Contributor Author

gmarouli commented Feb 9, 2022

@elasticmachine update branch

@gmarouli
Copy link
Contributor Author

@elasticmachine update branch

@gmarouli
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/bwc

@gmarouli gmarouli merged commit d4655e8 into elastic:master Feb 10, 2022
@gmarouli gmarouli deleted the stats-discard-intermediate-results-on-cancellation branch February 10, 2022 10:59
@DaveCTurner DaveCTurner mentioned this pull request Feb 14, 2022
Merged
@gmarouli gmarouli mentioned this pull request Jul 27, 2022
Merged
This was referenced Jan 17, 2023
Merged
Closed
This was referenced Oct 23, 2023
Merged
Merged
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Oct 23, 2023
@DaveCTurner
Improve cancellation in repo analysis
943f0d8 
Today we rely on an `isRunning` check to check for task cancellation,
but since elastic#82685 we can actively record the failure arising from the
cancellation using a `CancellationListener`.

Closes elastic#101197
DaveCTurner added a commit that referenced this pull request Oct 24, 2023
@DaveCTurner
Improve cancellation in repo analysis (#101213)
b714549 
Today we rely on an `isRunning` check to check for task cancellation,
but since #82685 we can actively record the failure arising from the
cancellation using a `CancellationListener`.

Closes #101197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner left review comments

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
>bug :Data Management/Stats Statistics tracking and retrieval APIs Team:Data Management Meta label for data/management team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stats actions should discard intermediate state on cancellation
5 participants
@gmarouli @elasticmachine @elasticsearchmachine @dakrone @DaveCTurner