Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.1] Avoid null threadContext in ResultDeduplicator (#84093) #84097

Merged
merged 1 commit into from
Feb 17, 2022
Merged

[8.1] Avoid null threadContext in ResultDeduplicator (#84093) #84097

merged 1 commit into from
Feb 17, 2022

Conversation

DaveCTurner
Copy link
Contributor

Backports the following commits to 8.1:

@DaveCTurner
Avoid null threadContext in ResultDeduplicator (elastic#84093)
dc3db06 
In elastic#84038 we added a dependency on having a valid `threadContext` in a
repository, but some tests use mocking and may end up with a `null`
here. This seems not to be a problem in recent branches but causes
failures in 8.0. With this commit we ensure that we always have a valid
`threadContext` to avoid any problems.
@DaveCTurner DaveCTurner added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport labels Feb 17, 2022
@elasticsearchmachine elasticsearchmachine mentioned this pull request Feb 17, 2022
Merged
@elasticsearchmachine elasticsearchmachine merged commit 5083e20 into elastic:8.1 Feb 17, 2022
@DaveCTurner DaveCTurner deleted the backport/8.1/pr-84093 branch February 17, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v8.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaveCTurner @elasticsearchmachine