-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch execute template and pipeline cluster state operations #86017
Batch execute template and pipeline cluster state operations #86017
Conversation
…te-and-pipeline-CS
…te-and-pipeline-CS
Pinging @elastic/es-data-management (Team:Data Management) |
Hi @dakrone, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me.
I do wonder about testing.
Each type of operation is tested (e.g. putting a pipeline) on the unit level and integration level. I think batching implementation is tested as well in ClusterStateService is tested as well. So I think we're good here, right?
@@ -1651,13 +1641,6 @@ private void validate(String name, @Nullable Settings settings, List<String> ind | |||
} | |||
} | |||
|
|||
public interface PutListener { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to see these listeners being replaced by ActionListener
I think so too, I think adding a test specifically for this would add a ton of complexity. |
Yes, I had a similar feeling that these tests require a lot of work without adding much benefit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
For future reference you can use |
This commit changes the cluster state operations for templates (legacy, component, and composable) as well as ingest pipelines to be bulk executed. This means that they can be processed much faster when creating/updating many simultaneously.
Relates to #77505