Reduce memory usage in field-caps responses #88042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
v7.17.5
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @dnhatn, I've created a changelog YAML for you. |
|
Heya @dnhatn, this change makes sense to me, good catch! Do you have numbers on the improvements when it comes to memory usage? Did you assess whether the change also has some effect on response time of field_caps? |
|
@javanna Thanks for looking. This PR doesn't reduce the latency significantly as we still send a full map over the wire. The current version hits OOM with 10 concurrent field-caps requests, but this change doesn't. |
dnhatn
requested review from
javanna
and removed request for
original-brownbear and
jtibshirani
javanna
approved these changes
Jun 28, 2022
server/src/main/java/org/elasticsearch/action/fieldcaps/FieldCapabilitiesIndexResponse.java
Show resolved
Hide resolved
I expect this PR reduces the memory usage by around 40%. |
|
@javanna Thanks for review. |
|
This will be in 7.17.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have reduced the memory usage of field-caps requests targeting many indices in 8.2+ (see #83494). Unfortunately, we still receive OOM reports in 7.17. I think we should push some contained improvements to reduce the memory usage for those requests in 7.17. I have looked into several options. This PR can reduce the memory usage of field-caps responses by replace HashMap with ArrayList for the field responses to eliminate duplicated string names and internal nodes of Map. I will look into other options, such as deduplicating field-name strings or field-responses.