Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up synthetic source again #89600

Merged
merged 2 commits into from
Aug 26, 2022

Commits on Aug 24, 2022

  1. Speed up synthetic source again

    When I added support for stored fields to synthetic _source (elastic#87480) I
    accidentally caused a performance regression. Our friends working on
    building the nightly charts for tsdb caught it. It looked like:
    ```
    |   50th percentile latency | default_1k | 20.1228 | 41.289  | 21.1662  | ms | +105.18% |
    |   90th percentile latency | default_1k | 26.7402 | 42.5878 | 15.8476  | ms |  +59.27% |
    |   99th percentile latency | default_1k | 37.0881 | 45.586  |  8.49786 | ms |  +22.91% |
    | 99.9th percentile latency | default_1k | 43.7346 | 48.222  |  4.48742 | ms |  +10.26% |
    |  100th percentile latency | default_1k | 46.057  | 56.8676 | 10.8106  | ms |  +23.47% |
    ```
    
    This fixes the regression and puts us in line with how we were:
    ```
    |   50th percentile latency | default_1k | 20.1228 | 24.023  |  3.90022 | ms |  +19.38% |
    |   90th percentile latency | default_1k | 26.7402 | 29.7841 |  3.04392 | ms |  +11.38% |
    |   99th percentile latency | default_1k | 37.0881 | 36.8038 | -0.28428 | ms |   -0.77% |
    | 99.9th percentile latency | default_1k | 43.7346 | 39.0192 | -4.71531 | ms |  -10.78% |
    |  100th percentile latency | default_1k | 46.057  | 42.9181 | -3.13889 | ms |   -6.82% |
    ```
    
    A 20% bump in the 50% latency isn't great, but it four microseconds per
    document which is acceptable.
    nik9000 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    afee04d View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Better split!

    nik9000 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    430099b View commit details
    Browse the repository at this point in the history