Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Export FileLayerField #73

Merged
merged 1 commit into from
Jul 19, 2021
Merged

[Maps] Export FileLayerField #73

merged 1 commit into from
Jul 19, 2021

Conversation

thomasneirynck
Copy link
Contributor

Closes #71

@thomasneirynck thomasneirynck requested review from jsanz and nickpeihl July 7, 2021 17:31
nickpeihl
nickpeihl approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

should this go into a 7.14 patch or wait until 7.15.0?

@thomasneirynck
Copy link
Contributor Author

should this go into a 7.14 patch or wait until 7.15.0?

7.15.0 is OK. Will remove shim from Kibana then as well.

@jsanz jsanz added the v7.15.0 label Jul 8, 2021
@nickpeihl
Copy link
Member

@thomasneirynck do you want to merge this? there is no 7.x branch so no need to backport it.

@thomasneirynck thomasneirynck merged commit bfc5e19 into elastic:master Jul 19, 2021
@thomasneirynck
Copy link
Contributor Author

thx @nickpeihl I'd forgotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

@jsanz jsanz Awaiting requested review from jsanz

Assignees
No one assigned
Labels
v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Export FileLayerField from client
3 participants
@thomasneirynck @nickpeihl @jsanz