Skip to content

Commit

Permalink
Use span for loaders and set width to kibana loader (#1845)
Browse files Browse the repository at this point in the history
Spans are now used for all the loaders. Fixed a bug in the kibana loader in flex layouts.
  • Loading branch information
snide authored Apr 17, 2019
1 parent 6579cb4 commit 6867a63
Show file tree
Hide file tree
Showing 16 changed files with 292 additions and 275 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@

- Converted `EuiText`, `EuiTextColor` and `EuiTextAlign` to TS ([#1791](https://github.com/elastic/eui/pull/1791))
- Updated `IconColor` type to better distinguish between accepted types ([#1842](https://github.com/elastic/eui/pull/1842))
- Changed `EuiLoadingKibana`, `EuiLoadingSpinner`, `EuiLoadingChart` and `EuiLoadingContent` components to use spans instead of divs ([#1845](https://github.com/elastic/eui/pull/1845))

**Bug fixes**

- Changed `EuiLoadingKibana` so it could better nest within `EuiFlexItem` ([#1845](https://github.com/elastic/eui/pull/1845))

## [`10.0.0`](https://github.com/elastic/eui/tree/v10.0.0)

Expand Down
2 changes: 1 addition & 1 deletion src/components/button/__snapshots__/button.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ exports[`EuiButton props isLoading is rendered 1`] = `
<span
class="euiButton__content"
>
<div
<span
class="euiLoadingSpinner euiLoadingSpinner--medium euiButton__spinner"
/>
<span
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ exports[`EuiFacetButton props isLoading is rendered 1`] = `
>
Content
</span>
<div
<span
class="euiLoadingSpinner euiLoadingSpinner--medium euiFacetButton__spinner"
/>
</span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ exports[`EuiFormControlLayout props isLoading is rendered 1`] = `
<div
class="euiFormControlLayoutIcons euiFormControlLayoutIcons--right"
>
<div
<span
class="euiLoadingSpinner euiLoadingSpinner--medium"
/>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ Array [
<div
class="euiFormControlLayoutIcons euiFormControlLayoutIcons--right"
>
<div
<span
class="euiLoadingSpinner euiLoadingSpinner--medium"
/>
<span
Expand Down
60 changes: 30 additions & 30 deletions src/components/loading/__snapshots__/loading_chart.test.tsx.snap
Original file line number Diff line number Diff line change
@@ -1,98 +1,98 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`EuiLoadingChart is rendered 1`] = `
<div
<span
aria-label="aria-label"
class="euiLoadingChart testClass1 testClass2 euiLoadingChart--medium"
data-test-subj="test subject string"
>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
</div>
</span>
`;

exports[`EuiLoadingChart mono is rendered 1`] = `
<div
<span
class="euiLoadingChart euiLoadingChart--mono euiLoadingChart--medium"
>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
</div>
</span>
`;

exports[`EuiLoadingChart size l is rendered 1`] = `
<div
<span
class="euiLoadingChart euiLoadingChart--large"
>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
</div>
</span>
`;

exports[`EuiLoadingChart size m is rendered 1`] = `
<div
<span
class="euiLoadingChart euiLoadingChart--medium"
>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
</div>
</span>
`;

exports[`EuiLoadingChart size xl is rendered 1`] = `
<div
<span
class="euiLoadingChart euiLoadingChart--xLarge"
>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
</div>
</span>
`;
Loading

0 comments on commit 6867a63

Please sign in to comment.