Skip to content

Commit

Permalink
Remove overflow: hidden from EuiModal styles that caused a red overla… (
Browse files Browse the repository at this point in the history
#6343)

* Remove overflow: hidden from EuiModal styles that caused a red overlay on the modals to appear when longer content is added to the modal This logic was added to assist with a bug in IE, and now that IE is out of service, this should be safe to remove

* CHANGELOG

* Update upcoming_changelogs/6343.md

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Update upcoming_changelogs/6343.md

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Restore overflow:hidden in the form of a comment to reconsider once the Chromium bug that is causing the red squares to appear is resolved.

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
  • Loading branch information
breehall and Constance authored Nov 3, 2022
1 parent 5e32012 commit b3e0797
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/components/modal/_modal.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
display: flex;
flex-direction: column;
max-height: 75vh; // We overflow the modal body based off this
overflow: hidden; // Ensure long, non-breaking text doesn't expand beyond the modal bounds

// TODO: Consider restoring this once https://bugs.chromium.org/p/chromium/issues/detail?id=1229700 is resolved
// overflow: hidden; Ensure long, non-breaking text doesn't expand beyond the modal bounds

position: relative;
background-color: $euiColorEmptyShade;
Expand Down
3 changes: 3 additions & 0 deletions upcoming_changelogs/6343.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed a webkit rendering issue with `EuiModal`s containing `EuiBasicTable`s tall enough to scroll

0 comments on commit b3e0797

Please sign in to comment.