Increase default font size of tabs in KUI theme (#1244)

elastic · Oct 18, 2018 · c05eb7c · c05eb7c
1 parent 6a328a8
commit c05eb7c
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
 ## [`master`](https://github.com/elastic/eui/tree/master)
 
-No public interface changes since `4.5.2`.
+- Increased default font size of tabs in K6 theme ([#1244](https://github.com/elastic/eui/pull/1244))
 
 ## [`4.5.2`](https://github.com/elastic/eui/tree/v4.5.2)
 

diff --git a/src/components/tabs/_index.scss b/src/components/tabs/_index.scss
@@ -1,4 +1,2 @@
-$tabBackgroundColor: #FFF;
-$tabHoverBackgroundColor: #F2F2F2;
-
+@import "variables";
 @import "tabs";
diff --git a/src/components/tabs/_tabs.scss b/src/components/tabs/_tabs.scss
@@ -13,7 +13,7 @@
 
   &.euiTabs--small {
     .euiTab {
-      @include euiFontSizeS;
+      @include fontSize($euiTabFontSizeS);
       padding: $euiSizeS $euiSizeS;
     }
   }
@@ -27,7 +27,8 @@
 }
 
 .euiTab {
-  @include euiFontSize;
+  @include fontSize($euiTabFontSize);
+  line-height: $euiLineHeight;
 
   position: relative;
   cursor: pointer;

diff --git a/src/components/tabs/_variables.scss b/src/components/tabs/_variables.scss
@@ -0,0 +1,2 @@
+$euiTabFontSize: $euiFontSize !default;
+$euiTabFontSizeS: $euiFontSizeS !default;
diff --git a/src/themes/k6/k6_globals.scss b/src/themes/k6/k6_globals.scss
@@ -14,3 +14,7 @@ $euiFontSizeXXL:    $euiFontSize * nth($euiTextScale, 1); // 32px
 
 // Make titles bold.
 $euiFontWeightLight: 600;
+
+// Ensure non-small tabs actually have a larger font size
+$euiTabFontSize: $euiFontSizeM;
+$euiTabFontSizeS: $euiFontSizeS;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		$euiTabFontSize: $euiFontSize !default;
		$euiTabFontSizeS: $euiFontSizeS !default;