Skip to content

Commit

Permalink
switch default to true
Browse files Browse the repository at this point in the history
  • Loading branch information
ryankeairns committed Sep 6, 2018
1 parent 2ff044b commit c11b1cd
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Added `maxWidth` prop to `EuiModal` ([#1165](https://github.com/elastic/eui/pull/1165))
- Added `infraApp` icon ([#1161](https://github.com/elastic/eui/pull/1161))
- Added sizes to `EuiButtonIcon` ([#1145](https://github.com/elastic/eui/pull/1145))
- Added `singleSelection.asPlainText` prop to `EuiComboBox` ([#1139](https://github.com/elastic/eui/pull/1139))
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/modal/modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class Modal extends Component {
<EuiOverlayMask>
<EuiModal
onClose={this.closeModal}
style={{ width: '800px' }}
style={{ width: '400px' }}
>
<EuiModalHeader>
<EuiModalHeaderTitle >
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/modal/modal_example.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export const ModalExample = {
}],
text: (
<p>
This demo is to test long overflowing body content. It also demonstrates the <EuiCode>maxWidth</EuiCode> property.
This demo is to test long overflowing body content.
</p>
),
props: { EuiConfirmModal },
Expand Down
1 change: 0 additions & 1 deletion src-docs/src/views/modal/overflow_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ export class OverflowTest extends Component {
<EuiOverlayMask>
<EuiModal
onClose={this.closeModal}
maxWidth
>
<EuiModalHeader>
<EuiModalHeaderTitle >
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`renders EuiConfirmModal 1`] = `
<div>
<div
aria-label="aria-label"
class="euiModal euiModal--confirmation testClass1 testClass2"
class="euiModal euiModal--maxWidth-default euiModal--confirmation testClass1 testClass2"
data-test-subj="test subject string"
tabindex="0"
>
Expand Down
2 changes: 1 addition & 1 deletion src/components/modal/__snapshots__/modal.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`renders EuiModal 1`] = `
<div>
<div
aria-label="aria-label"
class="euiModal testClass1 testClass2"
class="euiModal euiModal--maxWidth-default testClass1 testClass2"
data-test-subj="test subject string"
tabindex="0"
>
Expand Down
6 changes: 3 additions & 3 deletions src/components/modal/modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ EuiModal.propTypes = {
onClose: PropTypes.func.isRequired,
/**
* Sets the max-width of the modal.
* Set to `false` to not restrict the width,
* set to `true` to use the default (`euiBreakpoints 'm'`),
* Set to `true` to use the default (`euiBreakpoints 'm'`),
* set to `false` to not restrict the width,
* set to a number for a custom width in px,
* set to a string for a custom width in custom measurement.
*/
Expand All @@ -92,5 +92,5 @@ EuiModal.propTypes = {
};

EuiModal.defaultProps = {
maxWidth: false,
maxWidth: true,
};

0 comments on commit c11b1cd

Please sign in to comment.