Deprecate use of ghost
and ink
colors
#6820
-
Prior to having eui/src/themes/amsterdam/global_styling/variables/_colors.ts Lines 132 to 137 in afecfda Historically, in the cases of both the global/top
The caveat here is that the EUI components wrapped by the theme provider need to have been converted to Emotion which - as of this writing - is not complete. Do we need to wait for 100% conversion? No, but some of the outstanding component conversions are impacted by this (e.g. The point of this discussion item is to capture the new pattern and note that we will discontinue using eui/src/components/button/button.tsx Lines 53 to 55 in afecfda eui/src-docs/src/views/button/button_example.js Lines 721 to 723 in afecfda eui/src/components/button/button_icon/button_icon.tsx Lines 53 to 56 in afecfda eui/src/components/button/button_empty/button_empty.tsx Lines 58 to 61 in afecfda |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 2 replies
-
TODO: cross-check the outstanding Emotion conversions and their reliance upon these color values. |
Beta Was this translation helpful? Give feedback.
-
Taking a quick peek at Kibana usage: it looks like there's not as many https://github.com/search?q=repo%3Aelastic%2Fkibana%20color%3D%22ghost%22&type=code The <EuiButton color="ghost">
// becomes
<EuiThemeProvider colorMode="dark">
<EuiButton />
</EuiThemeProvider> <EuiTextColor color="ghost">
// becomes
<EuiTextColor color={euiTheme.colors.ghost}> <EuiLink color="ghost">
// deprecated entirely. or tell people to use a `<EuiThemeProvider colorMode="dark">` wrapper. Thoughts? |
Beta Was this translation helpful? Give feedback.
Update to this: #7296 removes
color="ghost"
from all button components.I'm leaning towards leaving
EuiText
,EuiTextColor
,EuiLink
andEuiIcon
alone in terms of allowing them to havecolor="ghost"
. Their usage of the prop isn't as problematic in terms of code.If you're okay with that, we can go ahead and close this discussion - does that work for you @ryankeairns?