Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header levels to CSS reset #1714

Closed
cchaos opened this issue Mar 12, 2019 · 1 comment · Fixed by #1760
Closed

Add header levels to CSS reset #1714

cchaos opened this issue Mar 12, 2019 · 1 comment · Fixed by #1760
Assignees

Comments

@cchaos
Copy link
Contributor

cchaos commented Mar 12, 2019

I thought we had this somewhere, and maybe it was only in Kibana at some point, but I think we should equal out all the h1 -> h6 tags in the CSS reset. Otherwise, if consumers use these tags outside of EuiTitle or EuiText they get the browser's default rendering.

Example usage

Someone placed an h2 tag inside a Vega tooltip so it's quite large:

Screen Shot 2019-03-11 at 22 36 32 PM

@snide
Copy link
Contributor

snide commented Mar 12, 2019

I dug into this a little more and there is an issue. I'll chat with @cchaos and we'll figure out the best way to handle it, but it will likely involve adjusting our reset file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants