Fix font reset for headings #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
commented
Mar 22, 2019
| @@ -96,7 +102,6 @@ button { | |||
| padding: 0; | |||
| margin: 0; | |||
| outline: none; | |||
| font-size: $euiFontSize; | |||
| font-size: inherit; | |||
There was a problem hiding this comment.
Line 99 was removed because it was being directly overridden by the inherit and therefore was having no effect but clutter.
|
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now targets h1-h6 and p tags to reset the family, weight and size to be similar to the base. This fixes #1714 where plain headings outside of EuiText were getting the browser's default applied which doesn't match our EuiText or EuiTitle styles.
Before
After
Buttons
I also added a font-size declaration for EuiButton's since they were getting inherited from their container, even though the overall size of the button was staying the same.
For example in tables:
Before
After
Checklist
[ ] This was checked in mobile[ ] This was checked in dark mode[ ] Any props added have proper autodocs[ ] Documentation examples were added[ ] This was checked for breaking changes and labeled appropriately[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X componentscc @zumwalt @gjones @formgeist
Even though this reset stopped existing only for a short while, I just wanted everyone to be alerted.