Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of EuiKeyPadMenuItemButton #2098

Closed
cchaos opened this issue Jul 8, 2019 · 2 comments · Fixed by #3062
Closed

Get rid of EuiKeyPadMenuItemButton #2098

cchaos opened this issue Jul 8, 2019 · 2 comments · Fixed by #3062
Labels
chore deprecations Contains deprecations. Add them to the deprecations meta ticket after merge.

Comments

@cchaos
Copy link
Contributor

cchaos commented Jul 8, 2019 •
edited
Loading

I just noticed that we have two components inside key_pad_menu_item.js file. One for links and one for buttons.

This was an old component that was created before our pattern of being able to pass an href or onClick and the component handles the correct html element. We should remove EuiKeyPadMenuItemButton in favor of just EuiKeyPadMenuItem that can also accept an onClick
@cchaos cchaos added chore assign:anyone deprecations Contains deprecations. Add them to the deprecations meta ticket after merge. labels Jul 8, 2019
@sjha2048
Copy link

hey @cchaos , Can I pick this issue?

@anishagg17
Copy link
Contributor

@sjha2048
I am working on It

@anishagg17 anishagg17 mentioned this issue Mar 12, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore deprecations Contains deprecations. Add them to the deprecations meta ticket after merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed EuiKeyPadMenuItemButton in favor of just EuiKeyPadMenuItem anishagg17/eui
3 participants
@cchaos @sjha2048 @anishagg17