-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed EuiKeyPadMenuItemButton
in favor of just EuiKeyPadMenuItem
#3062
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3062/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example text here https://github.com/elastic/eui/pull/3062/files#diff-4b25667c0abd98194144ace12c39a8beR88-R90 also needs to be updated
All changes have been made |
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3062/ |
This example text needs to be updated: eui/src-docs/src/views/key_pad_menu/key_pad_menu_example.js Lines 87 to 91 in ab84c3c
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost missed a major part of the issue. The rendered element needs to be a button
tag if it's an onClick
and an a
tag if there's an href
.
jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3062/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the changelog has been updated this should be good to go. Thanks 👍
Change Log has been shifted to correct position |
Jenkins, test this |
EuiKeyPadMenuItemButton
in favor of just EuiKeyPadMenuItem
Preview documentation changes for this PR: https://eui.elastic.co/pr_3062/ |
Summary
Fixes: #2098
removed EuiKeyPadMenuItemButton
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes