-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Control isExpandable at the cell level #2793
Comments
/cc @chandlerprall |
Before it even shows the expand button that is. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
This still seems useful. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error. |
@pickypg 👋 Heyyy!! I've recently joined the EUI team and am helping out with EuiDataGrid - I hadn't seen this issue until it closed just now. Just curious, is it still useful to the calendar you're building? No promises, but I'd be interested in picking this up at some point if so :) |
Hey @constancecchen, it would! However, we currently use the |
Cool cool, great to know! As a heads up I'm currently prioritizing issues/features that teams need or are requesting in order to roll out features (currently some from Discover and Security), so it might be a while for this - but if you decide to switch over to EuiDataGrid or that this would be a blocker for doing so, definitely let me know and feel free to re-open this issue whenever! |
@constancecchen Hello! This feature just came up in our teams standup today. Would be really useful to to control |
Nice! I'll re-open as this is a recent re-request, but to level-set expectations, we've got a whole lot on the datagrid backlog so it might be a while yet before this gets looked at! |
I am building a calendar using the DataGrid and I have run into the need to allow a small popover form, but only if the calendar day has stuff in it. For example, imagine that a manager wants to override a holiday to mark an engineer as working, it obviously is an unnecessary step if there is no holiday on that day.
I'd like an enhancement where, before it attempts to render the cell with
isDetails
set totrue
, (or the popover version), it would instead check if it even should. The easiest approach seems to be makingisExpandable
acallback | boolean | undefined
, which probably helps it to avoid invoking a function call for all cells anyway. For the best impact, this function would need be passed therowIndex
andcolumnId
just like the render cell function.The text was updated successfully, but these errors were encountered: