Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Control isExpandable at the cell level #2793

Closed
pickypg opened this issue Jan 25, 2020 · 11 comments · Fixed by #5667
Closed

[EuiDataGrid] Control isExpandable at the cell level #2793

pickypg opened this issue Jan 25, 2020 · 11 comments · Fixed by #5667

Comments

@pickypg
Copy link
Member

pickypg commented Jan 25, 2020

I am building a calendar using the DataGrid and I have run into the need to allow a small popover form, but only if the calendar day has stuff in it. For example, imagine that a manager wants to override a holiday to mark an engineer as working, it obviously is an unnecessary step if there is no holiday on that day.

image

I'd like an enhancement where, before it attempts to render the cell with isDetails set to true, (or the popover version), it would instead check if it even should. The easiest approach seems to be making isExpandable a callback | boolean | undefined, which probably helps it to avoid invoking a function call for all cells anyway. For the best impact, this function would need be passed the rowIndex and columnId just like the render cell function.

@pickypg
Copy link
Member Author

pickypg commented Jan 25, 2020

/cc @chandlerprall

@pickypg
Copy link
Member Author

pickypg commented Jan 25, 2020

I'd like an enhancement where, before it attempts to render the cell with isDetails set to true, (or the popover version), it would instead check if it even should.

Before it even shows the expand button that is.

@cchaos cchaos changed the title EuiDataGrid control isExpandable at the cell level [EuiDataGrid] Control isExpandable at the cell level Sep 20, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@pickypg
Copy link
Member Author

pickypg commented Mar 20, 2021

This still seems useful.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

github-actions bot commented Oct 3, 2021

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

@cee-chen
Copy link
Member

cee-chen commented Oct 4, 2021

@pickypg 👋 Heyyy!! I've recently joined the EUI team and am helping out with EuiDataGrid - I hadn't seen this issue until it closed just now. Just curious, is it still useful to the calendar you're building? No promises, but I'd be interested in picking this up at some point if so :)

@pickypg
Copy link
Member Author

pickypg commented Oct 4, 2021

Hey @constancecchen, it would! However, we currently use the EuiTable in place of the datagrid. We would be open to checking it out again, but I think this feature would be useful regardless.

@cee-chen
Copy link
Member

cee-chen commented Oct 4, 2021

Cool cool, great to know! As a heads up I'm currently prioritizing issues/features that teams need or are requesting in order to roll out features (currently some from Discover and Security), so it might be a while for this - but if you decide to switch over to EuiDataGrid or that this would be a blocker for doing so, definitely let me know and feel free to re-open this issue whenever!

@robert-seymour-numerated
Copy link

robert-seymour-numerated commented Oct 28, 2021

@constancecchen Hello! This feature just came up in our teams standup today. Would be really useful to to control isExpandable on a cell level. Consider a simple id table: id=1 should not be expandable. but id=12312312313 would be nice.

@cee-chen
Copy link
Member

Nice! I'll re-open as this is a recent re-request, but to level-set expectations, we've got a whole lot on the datagrid backlog so it might be a while yet before this gets looked at!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants