-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Expansion popover needs more customization #5310
Comments
cc @chandlerprall and @thompsongl Just wanted to get more convo going on this as I think there's some higher level decisions to make here before just yoloing into the code.
Do we intend to completely hand over the cell popover state to the consumer (i.e., they're now required to be fully in charge of setting their own
Just to make sure I'm on the same page - it appears to me that consumers already have complete control over popover contents via the Other random thoughts:
Edit: Went ahead and opened a PR for this: #5461 |
Thanks, Constance! I also have some thoughts to get down and discuss, but my other in-progress work has consumed my attention this week. I'll make this a priority next week. |
No worries at all! The last item (z-index) looks pretty straightforward at second glance so I might go ahead and tackle it and leave all the hard questions to you |
Was going through some of the items in our backlog and also noticed this: elastic/kibana#115341 @constancecchen , should the |
Yes, it will! You will be able to grab |
While the expansion popover was originally built purely to be a full view of the cell contents, there is a growing need to make it more complex/custom. Several things that are needed:
ref
#5590)popoverContents
API withrenderCellPopover
#5640)The text was updated successfully, but these errors were encountered: