Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCodeBlock] Possibility to show line numbers #3140

Closed
mmourafiq opened this issue Mar 21, 2020 · 6 comments · Fixed by #4993
Closed

[EuiCodeBlock] Possibility to show line numbers #3140

mmourafiq opened this issue Mar 21, 2020 · 6 comments · Fixed by #4993

Comments

@mmourafiq
Copy link

mmourafiq commented Mar 21, 2020

It would be nice to have a flag to show line numbers on EuiCodeBlock when not used inline.

e.g.

<EuiCodeBlock language={this.props.filetype} isCopyable={true} showLineNumbers={true}>
    {this.state.fileContent}
</EuiCodeBlock>
@cchaos cchaos changed the title Possibility to show line numbers on EuiCodeBlock [EuiCodeBlock] Possibility to show line numbers Sep 20, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

@mmourafiq
Copy link
Author

Too late I guess to keep this issue open?

@cchaos
Copy link
Contributor

cchaos commented Apr 19, 2021

@mouradmourafiq If this is still a high priority for you, feel free to reopen. Usually when we allow issues to auto-close, is because we haven't seen significant asks for the same and will be further out on our roadmap.

@mmourafiq
Copy link
Author

mmourafiq commented Apr 19, 2021

@cchaos thank you for the reply.

I don't think I can reopen the issue with my account, at least I don't see the reopen button in the UI.

@cchaos cchaos reopened this Apr 19, 2021
@mmourafiq
Copy link
Author

@cchaos thank you for reopening the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants