-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Remove react-syntax-highlighter from stack traces #100192
Comments
Pinging @elastic/apm-ui (Team:apm) |
See also #76849 for the DB statements. elastic/eui#3140 exists to add the ability to show line numbers in EuiCodeBlock. |
I couldn't find any usages of highlight.js. Was this already fixed? |
@sqren We use react-syntax-highlighter which uses highlight.js. Updating the title and description and reopening. |
Line numbers in EuiCodeBlock will be available after the next release: elastic/eui#4993 |
Line numbers now available in Kibana: https://elastic.github.io/eui/#/editors-syntax/code#line-numbers |
highlight.js has been removed from EUI, and our stack trace code blocks are one of the only places in kibana where it's still being used (through react-syntax-highlighter)
We had wanted to switch over to
EuiCodeBlock
s for these, but EUI does not yet support line numbers here. The line numbers are valuable for context in these views, so we do not want to get rid of them.Remove react-syntax-highlighter and use the capabilities from EUI and prism.js to provide syntax highlighting in these views.
Add line number capabilities to our own components or to EuiCodeBlock.
The text was updated successfully, but these errors were encountered: