Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Convert DB statement code box to EuiCode #76849

Closed
formgeist opened this issue Sep 7, 2020 · 4 comments · Fixed by #129193
Closed

[APM] Convert DB statement code box to EuiCode #76849

formgeist opened this issue Sep 7, 2020 · 4 comments · Fixed by #129193
Labels
enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

formgeist commented Sep 7, 2020 •
edited
Loading

Summary

Screenshot 2020-09-07 at 10 48 33

The current database statement is presented in a custom code block component, but we should move to use EuiCode (EUI example) for consistent look and feel in Kibana.

Screenshot 2020-09-07 at 10 47 25

Screenshot 2020-09-07 at 10 49 13

We have some challenges with the Kibana dark mode, which would also be resolved by changing to the new component.

image

One requirement is that we're able to pass the same syntax highlighting that we currently have in the code component.
@formgeist formgeist added Team:APM All issues that need APM UI Team support enhancement New value added to drive a business result labels Sep 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist formgeist mentioned this issue Sep 7, 2020
Closed
14 tasks
@smith smith mentioned this issue Jun 7, 2021
Open
@smith
Copy link
Contributor

smith commented Sep 22, 2021

EuiCodeBlock supports line numbers as of elastic/eui#4993, so we can replace the code we're using with that now.

@formgeist
Copy link
Contributor Author

Not sure that line numbers was a requirement to get this replaced?

@botelastic
Copy link

botelastic bot commented Mar 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale Used to mark issues that were closed for being stale label Mar 21, 2022
@botelastic botelastic bot removed the stale Used to mark issues that were closed for being stale label Mar 21, 2022
@boriskirov boriskirov mentioned this issue Apr 1, 2022
Merged
boriskirov added a commit that referenced this issue Apr 4, 2022
@boriskirov
[APM] Convert DB statement code box to EuiCode (#129193)
881a8ec 
* [APM] Convert DB statement code box to EuiCode
Closes #76849

* added a target_blank attribute to the link

* added target attribute and removed more code from the db statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Convert DB statement code box to EuiCode
4 participants
@smith @sorenlouv @formgeist @elasticmachine