Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSelect in EuiPopover] Focus trap requires two clicks when focus is on select #3172

Closed
snide opened this issue Mar 25, 2020 · 7 comments
Closed

Comments

@snide
Copy link
Contributor

snide commented Mar 25, 2020

To replicate

  1. Go to EuiExpression docs https://elastic.github.io/eui/#/forms/expression
  2. Click first expression.
  3. Change the dropdown
  4. Two clicks are required to exit the trap

This is not something specific to EuiExpression and I was able to replicate in the popover docs by adding a new select.

@snide
Copy link
Contributor Author

snide commented Mar 25, 2020

cc @mikecote since this is an issue he runs into often in Kibana.

@cchaos
Copy link
Contributor

cchaos commented Mar 25, 2020

Possibly similar to #2490

@lokeshrana9999
Copy link
Contributor

@snide, I would like to give it a try please assign me.

@shrey
Copy link
Contributor

shrey commented Jun 5, 2020

@snide Can I work on this issue?

@anishagg17
Copy link
Contributor

@snide Can I work on this issue?

it's not assigned to anyone. so , yes you can work upon this

@cchaos cchaos changed the title EuiPopover focus trap requires two clicks when focus is on EuiSelect [EuiSelect in EuiPopover] Focus trap requires two clicks when focus is on select Sep 20, 2020
@cchaos cchaos changed the title [EuiSelect in EuiPopover] Focus trap requires two clicks when focus is on select [EuiSelectable in EuiPopover] Focus trap requires two clicks when focus is on select Mar 19, 2021
@thompsongl
Copy link
Contributor

I don't think this is still an issue, but would like a second opinion

  1. The repro steps involve an EuiSelect not an EuiSelectable, so I may be misunderstanding
  2. It's possible that the switch to react-focus-on fixed this ([EuiFocusTrap] Use react-focus-on #3631; in July 2020)

@cchaos
Copy link
Contributor

cchaos commented Aug 31, 2021

I went back to an old PR to test: https://eui.elastic.co/pr_3630/#/forms/expression and the issue existed. I checked the referenced pr https://eui.elastic.co/pr_3631/#/forms/expression and the issue still existed. But I checked the most recent build (v.37.5.0) and the issue does not exist. So yes, I'd consider this fixed, just don't know when or how. 😆

@cchaos cchaos closed this as completed Aug 31, 2021
@cchaos cchaos changed the title [EuiSelectable in EuiPopover] Focus trap requires two clicks when focus is on select [EuiSelect in EuiPopover] Focus trap requires two clicks when focus is on select Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants