Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting UI] Index selection popover doesn't close on attempted save #80141

Closed
ymao1 opened this issue Oct 12, 2020 · 4 comments
Closed

[Alerting UI] Index selection popover doesn't close on attempted save #80141

ymao1 opened this issue Oct 12, 2020 · 4 comments
Assignees
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) UX

Comments

@ymao1
Copy link
Contributor

ymao1 commented Oct 12, 2020

Kibana version: 7.9

When creating an index threshold alert, if 'Save' is pressed while the index selection popover is open, the popover remains open. This leads to a potentially confusing experience if a confirmation modal opens in response to the 'Save' action. This may be true for other popovers on the flyout as well.

Before hitting save:
95489143-76d54500-0964-11eb-8e64-01b07f41ba9f

After hitting save:
95489154-7ccb2600-0964-11eb-8f36-020cc1064bba

@ymao1 ymao1 added Feature:Alerting UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor

To timebox 1hr to see if it's EUI bug (and open issue) or we'll re-triage otherwise.

@ymao1 ymao1 self-assigned this Oct 29, 2020
@ymao1
Copy link
Contributor Author

ymao1 commented Oct 29, 2020

I believe this issue is related to this EUI issue: elastic/eui#3172

This issue only occurs when the popover is open and the user is clicked into the EuiSelect "time field" component. It takes two clicks to close the popover when the user is in this state. For this particular issue, if the first click is on the 'Save' button, the save action is triggered, potentially popping up the confirmation modal.

Since this seems to be an EUI bug and there is already an issue open for it, it seems like we can close this issue.

@ymao1
Copy link
Contributor Author

ymao1 commented Nov 2, 2020

Issue should be fixed with elastic/eui#3172

@ymao1 ymao1 closed this as completed Nov 2, 2020
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) UX
Projects
None yet
Development

No branches or pull requests

5 participants