Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Increase Height" and "Decrease Height" buttons should provide context change information #721

Closed
aphelionz opened this issue Apr 28, 2018 · 4 comments · Fixed by #2939
Closed

"Increase Height" and "Decrease Height" buttons should provide context change information #721

aphelionz opened this issue Apr 28, 2018 · 4 comments · Fixed by #2939
Assignees
@anishagg17
Labels
accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue

Comments

@aphelionz
Copy link
Contributor

Steps to reproduce (assumes ChromeVox or similar)

image

  1. Open https://elastic.github.io/eui/#/layout/accordion in a new tab.
  2. Tab through to the "Accordion content can dynamically change height" section and focus the "Increase Height" button
  3. Press Enter

Actual Result

"Increase Height" is read repeatedly with no context as to what it is increasing, and to what

Expected Result

"Increase height to 3 items" => "Increase height to 4 items" etc, etc.

Category: #688: Elastic UI Buttons Accessibility
Relevant WCAG Criteria: [3.3.2 Input Assistance: Labels or Instructions(https://www.w3.org/WAI/WCAG20/quickref/#qr-minimize-error-cues)
@aphelionz aphelionz added accessibility accessibility - WCAG A Level A WCAG Accessibility Criteria labels Apr 28, 2018
@aphelionz aphelionz mentioned this issue Apr 28, 2018
Closed
2 tasks
@snide snide added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Jun 8, 2018
@anishagg17
Copy link
Contributor

@chandlerprall please assign me this issue

@chandlerprall
Copy link
Contributor

@anishagg17 done!

@anishagg17
Copy link
Contributor

@chandlerprall Do you want the change only in docs-view?

@chandlerprall
Copy link
Contributor

Ha! Yes. I don't think any of us caught that this would be docs only.

@anishagg17 anishagg17 mentioned this issue Feb 27, 2020
Merged
9 tasks
snide pushed a commit that referenced this issue Feb 28, 2020
@anishagg17
fixes #721 : Added context change to accordion in docs-view (#2939)
3550df4 
Updates docs to add more context to the accordion examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anishagg17 anishagg17

Labels
accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #721 : added context change to accordin in docs-view anishagg17/eui
4 participants
@aphelionz @chandlerprall @snide @anishagg17