Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiText] Remove img's from styling #7356

Closed
julianrosado opened this issue Nov 10, 2023 · 2 comments · Fixed by #7360
Closed

[EuiText] Remove img's from styling #7356

julianrosado opened this issue Nov 10, 2023 · 2 comments · Fixed by #7360
Assignees

Comments

@julianrosado
Copy link

Is your feature request related to a problem? Please describe.

[EuiText] adds a margin-bottom to a number of text elements and also img's . See styles. Presumably this is to account for img float's as described in EUI documentation.

This has an unintended side effect of add margin's to images that are added to things such as callouts, necessitating some style overrides.

While, admittedly, images in callouts are not a common feature, I would argue image floats in Kibana are an even rarer bird.

Describe the solution you'd like
Remove img 's from having their styles modified by EuiText

Describe alternatives you've considered
The one went with was a recommendation by @cee-chen to override the margin with !important styles.

Desired timeline
No specific deadline

Additional context
Reach out if you want an image!

@cee-chen
Copy link
Contributor

Here's a quick CodeSandbox demonstrating the problem with EuiCallOut specifically: https://codesandbox.io/s/old-shadow-vlxpgt?file=/demo.tsx

@cee-chen
Copy link
Contributor

cee-chen added a commit to cee-chen/kibana that referenced this issue Dec 21, 2023
- now that we're no longer opinionatedly adding margins to `<img>` tags within EuiText

- see elastic/eui#7356 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants