Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing EuiPageContent layout #1024

Merged
merged 2 commits into from
Jul 18, 2018
Merged

Fixing EuiPageContent layout #1024

merged 2 commits into from
Jul 18, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jul 18, 2018

Ensures that the auto margins only apply to the sides that are being centered.

Also, I added the restrictWidth functionality to the EuiPageBody component as well to help with out layouts in Kibana where we're hacking the background color onto EuiPage.

@cchaos cchaos requested a review from snide July 18, 2018 14:58
snide
snide approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job adding the number option on here.

@cchaos cchaos merged commit f2312b5 into elastic:master Jul 18, 2018
@cchaos cchaos deleted the page-fix branch July 18, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cchaos @snide