Added support for fullWidth on EuiComboBox
#1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can easily be tested by changing the default value to true: https://github.com/elastic/eui/pull/1095/files#diff-1cc70a22af114baf29d4d6dab3201c29R53 |
snide
approved these changes
Aug 7, 2018
| @@ -6,7 +6,7 @@ | |||
| * 3. The height can expand, hence auto | |||
| */ | |||
| .euiComboBoxOptionsList { | |||
| @include euiFormControlSize(auto); /* 3 */ | |||
| @include euiFormControlSize(auto, $includeAlternates: true); /* 3 */ | |||
There was a problem hiding this comment.
Somehow I missed this addition to the mixin. That's really cool 👍
There was a problem hiding this comment.
Yeah, it's been really helpful. Eventually I might want to do a check in the mixin to see if the value passed is a bool or string, where the string could match "fullWidth" or "compressed", or an array of stings. So we can be even more particular about which ones to include.
cchaos
force-pushed
the
combobox-full-width
branch
from
fab57a1
to
7ad772c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1062
Link to gif: https://d.pr/free/i/SEuUIY