Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default font size of tabs in KUI theme #1244

Merged
merged 3 commits into from
Oct 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `4.5.2`.
- Increased default font size of tabs in K6 theme ([#1244](https://github.com/elastic/eui/pull/1244))

## [`4.5.2`](https://github.com/elastic/eui/tree/v4.5.2)

Expand Down
4 changes: 1 addition & 3 deletions src/components/tabs/_index.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
$tabBackgroundColor: #FFF;
$tabHoverBackgroundColor: #F2F2F2;

@import "variables";
@import "tabs";
5 changes: 3 additions & 2 deletions src/components/tabs/_tabs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

&.euiTabs--small {
.euiTab {
@include euiFontSizeS;
@include fontSize($euiTabFontSizeS);
padding: $euiSizeS $euiSizeS;
}
}
Expand All @@ -27,7 +27,8 @@
}

.euiTab {
@include euiFontSize;
@include fontSize($euiTabFontSize);
line-height: $euiLineHeight;

position: relative;
cursor: pointer;
Expand Down
2 changes: 2 additions & 0 deletions src/components/tabs/_variables.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
$euiTabFontSize: $euiFontSize !default;
$euiTabFontSizeS: $euiFontSizeS !default;
4 changes: 4 additions & 0 deletions src/themes/k6/k6_globals.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,7 @@ $euiFontSizeXXL: $euiFontSize * nth($euiTextScale, 1); // 32px

// Make titles bold.
$euiFontWeightLight: 600;

// Ensure non-small tabs actually have a larger font size
$euiTabFontSize: $euiFontSizeM;
$euiTabFontSizeS: $euiFontSizeS;