Description list framer component #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
commented
Nov 1, 2018
| @@ -1,6 +1,6 @@ | |||
| ## [`master`](https://github.com/elastic/eui/tree/master) | |||
|
|
|||
| No public interface changes since `4.7.0`. | |||
| - Added Framer component for `EuiDescirptionList` ([#1276](https://github.com/elastic/eui/pull/1276)) | |||
There was a problem hiding this comment.
Should I make a Framer subhead for this stuff? Probably?
There was a problem hiding this comment.
Makes sense to have one
chandlerprall
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a version of the
EuiDescriptionListcomponent to Framer. To make things easier to use in Framer, it creates a single row containingEuiDescriptionListTitleandEuiDescriptionListDescriptionso you don't need to pass a full list. I added Framer props for the text content of these two.Testing
I've published this in the Framer Store. Simply install it and have fun.
Checklist
Not required.