Remove styling from hover state of empty buttons #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry Dave, saw this in the am as I was doing an errand and plum forgot to come back to it. 👍 though! |
|
Dave, this is missing a thing: https://github.com/elastic/eui/blob/169e1066c4e86ad1f1258957588371e48929fcd0/CHANGELOG.md - Changed the hover states of EuiButtonEmpty to look more like links.Should be: - Changed the hover states of EuiButtonEmpty to look more like links. [(#135)](https://github.com/elastic/eui/pull/135)Maybe even: - Changed the hover states of `<EuiButtonEmpty>` to look more like links. [(#135)](https://github.com/elastic/eui/pull/135)❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134 at the request of @zinckiwi
For the moment, I'm keeping it on EmptyButtonIcon. I can't really underline the icons, so this solution doesn't work well for them. Likely I'll think up a better way to handle those then doing the background, but that can be a later PR.