[EuiSuperDatePicker] add showRefreshOnly prop #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cchaos Here is the prop we talked about that turns the EuiSuperDatePicker into just an interval UI. What do you think? Below are some screen shots of what Kibana looks like when there is no time picker. This component would replace this view
|
cchaos
reviewed
Jan 7, 2019
| @@ -80,24 +119,12 @@ export default class extends Component { | |||
| onRefreshChange={this.onRefreshChange} | |||
| recentlyUsedRanges={this.state.recentlyUsedRanges} | |||
| showUpdateButton={this.state.showUpdateButton} | |||
| showRefreshOnly={this.state.showRefreshOnly} | |||
There was a problem hiding this comment.
This prop name is confusing because I think that's it's referring to the Update/Refresh button. Can you rename to isAutoRefreshOnly?
| @@ -59,6 +60,10 @@ export class EuiSuperDatePicker extends Component { | |||
| * Set showUpdateButton to false to immediately invoke onTimeChange for all start and end changes. | |||
| */ | |||
| showUpdateButton: PropTypes.bool, | |||
| /** | |||
| * | |||
There was a problem hiding this comment.
Can you add a documentation comment here explaining what the prop does?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds showRefreshOnly prop to EuiSuperDatePicker. When set to true, only the refresh interval and isPaused can be modified