Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button group fixes #1444

Merged
merged 6 commits into from
Jan 16, 2019
Merged

Button group fixes #1444

merged 6 commits into from
Jan 16, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jan 16, 2019 •
edited
Loading

1. Makes sure hidden selectable inputs are still hidden when disabled

This is what would happen in Kibana. So I just !importanted the opacity: 0 of the hidden input.

screen shot 2019-01-16 at 14 10 00 pm

2. Adds better accessibility to the groups by using fieldset and legend

But legend is only screen-reader accessible. Which works great with the Mac OS screen reader:

But Chrome Vox doesn't...

But it's the same functionality as https://www.w3.org/WAI/tutorials/forms/grouping/

Anyone have any thoughts? Acceptable? Or different approach?

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • [ ] This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • [ ] Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

@cchaos cchaos requested review from chandlerprall and snide January 16, 2019 19:15
snide
snide approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Only a small comment on the proptype, but tested and LGTM.

src/components/button/button_group/button_group.js Outdated Show resolved Hide resolved
@cchaos cchaos force-pushed the button_group_fixes branch from e11e4de to e8263ca Compare January 16, 2019 19:28
@cchaos cchaos force-pushed the button_group_fixes branch from e8263ca to e2d2af9 Compare January 16, 2019 19:51
@cchaos cchaos merged commit e2b98b3 into elastic:master Jan 16, 2019
@cchaos cchaos deleted the button_group_fixes branch January 16, 2019 20:01
@cchaos
Copy link
Contributor Author

cchaos commented Jan 16, 2019

cc @legrego

@snide snide mentioned this pull request Jan 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

@chandlerprall chandlerprall Awaiting requested review from chandlerprall

Assignees
No one assigned
Labels
accessibility bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cchaos @snide