Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes header logo width and updates drawer example #1449

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Fixes header logo width and updates drawer example #1449

merged 1 commit into from
Jan 17, 2019

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Jan 17, 2019 •
edited
Loading

Summary

I got crossed up checking between EUI and Kibana for the precise EuiHeaderLogo width and was off by 1px. This PR adds that extra 1px width to account for the right border while also updating the EuiNavDrawer docs example to use EuiHeaderLogo (to match the Kibana setup and the Header docs example).

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@ryankeairns
Copy link
Contributor Author

This should be the last tweak before I open the side nav PR on the Kibana side. 🤞

cchaos
cchaos approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ryankeairns ryankeairns merged commit 2daf98d into elastic:master Jan 17, 2019
@snide snide mentioned this pull request Jan 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@snide snide snide approved these changes

@chandlerprall chandlerprall Awaiting requested review from chandlerprall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryankeairns @snide @cchaos