Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t reduce header at at mobile size #1480

Merged
merged 3 commits into from
Jan 28, 2019
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `6.7.1`.
- `EuiHeader` no longer reduces height at mobile sizes ([#1480](https://github.com/elastic/eui/pull/1480))

## [`6.7.1`](https://github.com/elastic/eui/tree/v6.7.1)

Expand Down
3 changes: 1 addition & 2 deletions src/components/header/_header_logo.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
position: relative;
height: $euiHeaderChildSize;
line-height: $euiHeaderChildSize;
min-width: $euiHeaderChildSize + 1px;
padding: 0 ($euiSizeM + 1px) 0 $euiSizeM;
display: inline-block;
vertical-align: middle;
Expand All @@ -31,8 +32,6 @@

@include euiBreakpoint('xs') {
.euiHeaderLogo {
height: $euiHeaderChildSize * .75;
line-height: $euiHeaderChildSize * .75;
padding: 0 $euiSizeM;
}

Expand Down
1 change: 0 additions & 1 deletion src/components/header/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,3 @@ $euiHeaderBreadcrumbColor: $euiColorDarkestShade;

// Layout vars
$euiHeaderChildSize: $euiSizeXXL + $euiSizeS;
$euiHeaderChildSizeMobile: $euiHeaderChildSize * .75;
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

.euiHeaderSectionItem__button {
height: $euiHeaderChildSize;
min-width: $euiHeaderChildSize + 1px;
min-width: $euiHeaderChildSize;
text-align: center;
font-size: 0; // aligns icons better vertically

Expand Down Expand Up @@ -53,8 +53,7 @@
@include euiBreakpoint('xs') {
.euiHeaderSectionItem,
.euiHeaderSectionItem__button {
height: $euiHeaderChildSizeMobile;
min-width: $euiHeaderChildSizeMobile;
min-width: $euiHeaderChildSize * .75;
}

.euiHeaderSectionItem--borderLeft,
Expand All @@ -67,7 +66,7 @@
// On small screens just show a small dot indicating there are notifications
.euiHeaderNotification {
@include size($euiSizeS);

top: 20%;
min-width: 0;
border-radius: $euiSizeS;
color: $euiColorAccent;
Expand Down
7 changes: 0 additions & 7 deletions src/components/nav_drawer/_nav_drawer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,3 @@
}
}
}

@include euiBreakpoint('xs') {
.euiNavDrawer {
height: calc(100% - #{$euiNavDrawerTopPositionMobile});
top: $euiNavDrawerTopPositionMobile;
}
}
3 changes: 1 addition & 2 deletions src/components/nav_drawer/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@ $euiNavDrawerSideShadow: 2px 0 2px -1px rgba($euiShadowColor, .3);

// Layout variables
$euiNavDrawerTopPosition: $euiHeaderChildSize + 1px;
$euiNavDrawerTopPositionMobile: $euiHeaderChildSizeMobile + 1px;

// Animation variables
$euiNavDrawerExpandingDelay: $euiAnimSpeedNormal;
$euiNavDrawerContractingDelay: $euiAnimSpeedSlow;
$euiNavDrawerExtendedDelay: $euiAnimSpeedExtraSlow * 2;
$euiNavDrawerMenuAddedDelay: $euiAnimSpeedExtraFast;
$euiNavDrawerMenuAddedDelay: $euiAnimSpeedExtraFast;