-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeScript]: EuiToggle, EuiButtonGroup, EuiButtonToggle, EuiFilterButton, EuiFilterGroup, EuiFilterSelectItem #1570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a functionality scan of the components listed. All work and display auto docs as I'd expect. I did not scan the code other than doing a brief check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
Summary
EuiToggle
to TypeScript ( drop in the bucket [META] TypeScript conversion of EUI #1557 )EuiButtonGroup
andEuiButtonToggle
( resolves Missing TS defs: EuiButtonGroup, EuiButtonToggle #1566 )EuiFilterButton
,EuiFilterGroup
, andEuiFilterSelectItem
( resolves EuiFilterGroup / EuiFilterButton / EuiFilterSelectItem missing TypeScript definition #1492 🌊 🔵 )Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] This was checked for breaking changes and labeled appropriately- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components