Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript]: EuiToggle, EuiButtonGroup, EuiButtonToggle, EuiFilterButton, EuiFilterGroup, EuiFilterSelectItem #1570

Merged
merged 10 commits into from
Feb 21, 2019

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Feb 15, 2019

Summary

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode
- [ ] Any props added have proper autodocs
- [ ] Documentation examples were added

  • A changelog entry exists and is marked appropriately

- [ ] This was checked for breaking changes and labeled appropriately

  • Jest tests were updated or added to match the most common scenarios

- [ ] This was checked against keyboard-only and screenreader scenarios
- [ ] This required updates to Framer X components

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a functionality scan of the components listed. All work and display auto docs as I'd expect. I did not scan the code other than doing a brief check.

src/components/button/index.d.ts Outdated Show resolved Hide resolved
src/components/button/index.d.ts Outdated Show resolved Hide resolved
src/components/button/index.d.ts Outdated Show resolved Hide resolved
src/components/button/index.d.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@thompsongl thompsongl merged commit 1da5c71 into elastic:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants