Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert loading components to TS, fix ie11 shadow #1683

Merged
merged 5 commits into from
Mar 7, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Mar 6, 2019

Summary

Fixes #1440
Fixes elastic/kibana#25584

Converts the loading components over to TS and addresses a minor IE error

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide requested review from thompsongl and cchaos March 6, 2019 00:37
@snide snide changed the title Loading to TS, fix ie11 shadow Convert loading components to TS, fix ie11 shadow Mar 6, 2019
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick code review. Had a few suggestions/questions but mostly looks right.

src/components/loading/loading_chart.tsx Outdated Show resolved Hide resolved
src/components/loading/loading_chart.tsx Outdated Show resolved Hide resolved
src/components/loading/loading_spinner.tsx Outdated Show resolved Hide resolved
src/components/loading/loading_chart.test.tsx Show resolved Hide resolved
src/components/loading/loading_spinner.tsx Outdated Show resolved Hide resolved
src/components/loading/loading_chart.tsx Outdated Show resolved Hide resolved
src/components/loading/loading_chart.tsx Outdated Show resolved Hide resolved
src/components/loading/loading_kibana.tsx Outdated Show resolved Hide resolved
src/components/loading/loading_kibana.tsx Outdated Show resolved Hide resolved
src/components/loading/loading_spinner.tsx Outdated Show resolved Hide resolved
@snide
Copy link
Contributor Author

snide commented Mar 6, 2019

@cchaos @chandlerprall OK. Ready for another round. Tests added and snippets added as well.

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, checked in IE, chrome, and FF. I did notice one weird issue in FF:

screen shot 2019-03-07 at 09 58 05 am

But we can address that later?

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; tested loading docs locally

@snide
Copy link
Contributor Author

snide commented Mar 7, 2019

@cchaos I checked into this. I'm worried this might be something due to the changes in our portal / focus trap stuff. It looks like there is an awful lot of extra empty divs wrapping the pop over that don't have a zindex assigned (the popover here has one of 0).

I don't think this is related to this PR, but it's likely something @thompsongl should take a look at.

@snide snide merged commit cb5c369 into elastic:master Mar 7, 2019
@snide snide deleted the ts/loading branch March 7, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kibana bouncing loader shadow is off in IE11 Import animation for saved objects is malformed on IE11
3 participants