-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert loading components to TS, fix ie11 shadow #1683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick code review. Had a few suggestions/questions but mostly looks right.
Co-Authored-By: snide <dave.snider@gmail.com>
@cchaos @chandlerprall OK. Ready for another round. Tests added and snippets added as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; tested loading docs locally
@cchaos I checked into this. I'm worried this might be something due to the changes in our portal / focus trap stuff. It looks like there is an awful lot of extra empty divs wrapping the pop over that don't have a zindex assigned (the popover here has one of 0). I don't think this is related to this PR, but it's likely something @thompsongl should take a look at. |
Summary
Fixes #1440
Fixes elastic/kibana#25584
Converts the loading components over to TS and addresses a minor IE error
Checklist
This was checked in mobileThis was checked in dark modeThis was checked for breaking changes and labeled appropriatelyThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components