Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow EuiListGroupItem to pass a custom element as the icon #1726

Merged
merged 2 commits into from
Mar 13, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Mar 13, 2019

This is required for the nav in Kibana where plugins can provide their own (non-EuiIcon icon type) icon/image.

Example using an avatar:

Also beefed up the test cases.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • [ ] Documentation examples were added I specifically didn't add an example as it's a very low use case
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

This is required for the nav in Kibana
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM!

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will add an issue to show this use case in the docs, which we likely want to have so we can accurately monitor it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants