Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted EuiFormErrorText to TS #1772

Merged
merged 7 commits into from
Apr 1, 2019
Merged

Converted EuiFormErrorText to TS #1772

merged 7 commits into from
Apr 1, 2019

Conversation

theodesp
Copy link
Contributor

@theodesp theodesp commented Mar 27, 2019 •
edited
Loading

Summary

As per #1557

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cchaos
Copy link
Contributor

cchaos commented Mar 27, 2019

This is only a small part of the larger META ticket, so it doesn't need the [META] distinction in the PR title.

@thompsongl
Copy link
Contributor

jenkins test this

thompsongl
thompsongl suggested changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Two changes to make:

  1. src/components/form/form_error_text/index.d.ts can become src/components/form/form_error_text/index.ts
  2. src/components/form/form_error_text/index.js should then be deleted

@theodesp
Copy link
Contributor Author

@thompsongl I've updated the PR

thompsongl
thompsongl previously approved these changes Mar 29, 2019
View reviewed changes
@cchaos cchaos changed the title [META] - Converted EuiFormErrorText to TS Converted EuiFormErrorText to TS Mar 29, 2019
@thompsongl thompsongl dismissed their stale review March 29, 2019 13:46

Needs update

thompsongl
thompsongl suggested changes Mar 29, 2019
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@theodesp
Copy link
Contributor Author

@thompsongl PR updated

@chandlerprall chandlerprall merged commit e99ffaa into elastic:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theodesp @elasticmachine @cchaos @thompsongl @chandlerprall